Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-shell): refresh app shell UX #2102

Merged
merged 16 commits into from
Feb 26, 2024
Merged

feat(app-shell): refresh app shell UX #2102

merged 16 commits into from
Feb 26, 2024

Conversation

owilliams320
Copy link
Collaborator

@owilliams320 owilliams320 commented Feb 22, 2024

Description

Refreshing the app shell experience to support the new TD products branding

What's included?

  • CSS updates to appshell and scrolling
  • Moving the user-menu slot from the navigation section to above the main area
  • Help menu styling improvements
  • Styling adjustments to the breadcrumbs in markdown-navigator-component
  • Adding a contained property to app shell that wraps the main area in a card styling
  • Adding support for a dense property for textfield
  • Adding more support to use covalent-icon(s) attribute on the cv-icon component
  • Adding support for sticky mode for toolbar
  • Exporting missing secondary entry points for some packages

Test Steps

  • npm run storybook
  • then this open the app shell story
  • finally test out the new app shell improvements

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker
Screenshot 2024-02-21 at 10 48 39 PM Screenshot 2024-02-08 at 12 05 25 PM

@owilliams320 owilliams320 force-pushed the beta branch 2 times, most recently from 2fe9fd2 to ef06e6f Compare February 22, 2024 04:15
mikespudwebb
mikespudwebb previously approved these changes Feb 26, 2024
Copy link
Collaborator

@mikespudwebb mikespudwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

One comment about redundant imports and one question about borders. But I'm good with them, so :shipit:

libs/components/src/list/list.scss Show resolved Hide resolved
@owilliams320 owilliams320 merged commit a46449e into main Feb 26, 2024
@owilliams320 owilliams320 deleted the beta branch February 26, 2024 19:32
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 8.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants