-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-shell): refresh app shell UX #2102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owilliams320
force-pushed
the
beta
branch
2 times, most recently
from
February 22, 2024 04:15
2fe9fd2
to
ef06e6f
Compare
mikespudwebb
previously approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
One comment about redundant imports and one question about borders. But I'm good with them, so
mikespudwebb
approved these changes
Feb 26, 2024
🎉 This PR is included in version 8.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refreshing the app shell experience to support the new TD products branding
What's included?
user-menu
slot from the navigation section to above the main areamarkdown-navigator-component
contained
property to app shell that wraps the main area in a card stylingdense
property for textfieldcv-icon
componentTest Steps
npm run storybook
General Tests for Every PR
npm run start
still works.npm run lint
passes.npm run stylelint
passes.npm test
passes and code coverage is not lower.npm run build
still works.Screenshots or link to StackBlitz/Plunker