Update sim vision system #31
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "fileName": "photonlib.json", | ||
| "name": "photonlib", | ||
| "version": "v2025.1.1", | ||
| "uuid": "515fe07e-bfc6-11fa-b3de-0242ac130004", | ||
| "frcYear": "2025", | ||
| "mavenUrls": [ | ||
|
|
@@ -13,7 +13,7 @@ | |
| { | ||
| "groupId": "org.photonvision", | ||
| "artifactId": "photontargeting-cpp", | ||
|
There was a problem hiding this comment. ⭐ ⭐ ⭐ there's also a photonlib.json inside the SeriouslyCommonLib submodule repo you'll need to update at the same time There was a problem hiding this comment. just made this PR for SeriouslyCommonLib Team488/SeriouslyCommonLib#513 |
||
| "version": "v2025.1.1", | ||
| "skipInvalidPlatforms": true, | ||
| "isJar": false, | ||
| "validPlatforms": [ | ||
|
|
@@ -28,7 +28,7 @@ | |
| { | ||
| "groupId": "org.photonvision", | ||
| "artifactId": "photonlib-cpp", | ||
| "version": "v2025.1.1", | ||
| "libName": "photonlib", | ||
| "headerClassifier": "headers", | ||
| "sharedLibrary": true, | ||
|
|
@@ -43,7 +43,7 @@ | |
| { | ||
| "groupId": "org.photonvision", | ||
| "artifactId": "photontargeting-cpp", | ||
| "version": "v2025.1.1", | ||
| "libName": "photontargeting", | ||
| "headerClassifier": "headers", | ||
| "sharedLibrary": true, | ||
|
|
@@ -60,12 +60,12 @@ | |
| { | ||
| "groupId": "org.photonvision", | ||
| "artifactId": "photonlib-java", | ||
| "version": "v2025.1.1" | ||
| }, | ||
| { | ||
| "groupId": "org.photonvision", | ||
| "artifactId": "photontargeting-java", | ||
| "version": "v2025.1.1" | ||
| } | ||
| ] | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AprilTagVision stuff we copied in from Maple-sim-skeleton was using the 2025, this is some of our ported over vision code from 2024 that isn't being used yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you planning to eventually use this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No current plans, the new maple skeleton stuff seems to be working well so far but maybe we have to revisit that later