Update sim vision system #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschokking
approved these changes
Jan 25, 2025
| @@ -13,7 +13,7 @@ | |||
| { | |||
| "groupId": "org.photonvision", | |||
| "artifactId": "photontargeting-cpp", | |||
| "version": "v2025.0.0-beta-8", | |||
There was a problem hiding this comment.
⭐ ⭐ ⭐ there's also a photonlib.json inside the SeriouslyCommonLib submodule repo you'll need to update at the same time
There was a problem hiding this comment.
just made this PR for SeriouslyCommonLib Team488/SeriouslyCommonLib#513
| @@ -67,7 +67,7 @@ public VisionSubsystem(PropertyFactory pf, XCameraElectricalContract electricalC | |||
| // we need to handle cases like not having the AprilTag data loaded. | |||
|
|
|||
| try { | |||
| aprilTagFieldLayout = AprilTagFieldLayout.loadFromResource(AprilTagFields.k2024Crescendo.m_resourceFile); | |||
| aprilTagFieldLayout = AprilTagFieldLayout.loadFromResource(AprilTagFields.k2025Reefscape.m_resourceFile); | |||
There was a problem hiding this comment.
The AprilTagVision stuff we copied in from Maple-sim-skeleton was using the 2025, this is some of our ported over vision code from 2024 that isn't being used yet
There was a problem hiding this comment.
are you planning to eventually use this?
There was a problem hiding this comment.
No current plans, the new maple skeleton stuff seems to be working well so far but maybe we have to revisit that later
JohnGilb
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
update VIsion subsystem AprilTagFieldLayout to 2025
and update photon lib venderdeps
Whats changing?
photonlib venderop json and aprilTagFieldLayout in VisionSubsystem
Questions/notes for reviewers
How this was tested
PR feedback legend