-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/#361] 공연 수정하기 Step2(스태프&캐스트 리스트) 수정 가능하도록 변경 + 상세 이미지 추가 및 변경 #379
Closed
Closed
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
09c961f
feat: step2(스태프리스트,캐스트리스트 수정) 부활
ocahs9 b755519
fix: 입력 가능하도록 변경, 삭제 버튼 활성화
ocahs9 6a04442
feat: 타입 최신화
ocahs9 8644f2a
fix: 바뀐 api 명세에 맞게 타입 선언, 함수 설정
ocahs9 2237165
fix: request 보낼 속성 이름으로 수정(코드 가독성 향상 목적)
ocahs9 f3742d7
fix: 좀 더 가독성 좋도록 makerId로 이름 통일
ocahs9 92b07ed
feat: 새롭게 추가된 maker(staff,cast)인지 판단하여 id 추가 여부를 결정하는 로직 구현
ocahs9 58fd1e6
fix: id가 없는 경우도 있을 것 같아서, 옵셔널로 변경
ocahs9 d403a2e
fix: map, every가 안되는 경우도 고려하여 ?. 연산자 사용
ocahs9 33c312d
fix: undefinde라 map을 사용할 수 없다는 문제 해결 - 받아오는 데이터 타입 제대로 설정
ocahs9 e4085bf
fix: 옵셔널에 .? 연산자를 안주어서 생긴 Cannot read properties of undefined 해결
ocahs9 5b60d0b
chore: 수정하기 요청 500에러 나는 이유 주석 기술
ocahs9 4d2ecde
fix: 총 회차 수 동적으로 조절
ocahs9 d7fcc5f
fix: api로 받아온 값 읽지 못하는 버그 수정
ocahs9 8c66b91
feat: 상세 이미지 타입 추가
ocahs9 f9c086f
Merge branch 'develop' into feat/#361/ModifyManageStep2
ocahs9 b2df460
fix: dataState가 잘 찼는지 확인하기 위해 type 일부 옵셔녈로 변경
ocahs9 ed25e81
fix: 상세이미지 수정 가능하도록 타입 정의, 컴포넌트 추가
ocahs9 8ed463a
fix: 잘못된 err 반환으로 인해 alert 안 뜨는 문제 수정
ocahs9 04b8f1c
fix: open-api 타입 최신화
ocahs9 b84274e
fix: 에러 객체를 정상적으로 받아 사용할 수 있도록 수정
ocahs9 e79c73f
Merge branch 'develop' into feat/#361/ModifyManageStep2
ocahs9 73bab41
상세 이미지까지 추가해서 공연 수정하기 api 구성
ocahs9 234d3ce
fix: 공연 수정하기 조회 api에서 상세 이미지 안 불러오던 버그 해결
ocahs9 d460dc0
fix: 공연 소개 500자로 변경
ocahs9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,6 +121,20 @@ export const FileInputWrapper = styled.div` | |
gap: 1.4rem; | ||
`; | ||
|
||
export const FilesInputWrapper = styled.div` | ||
position: relative; | ||
|
||
${Generators.flexGenerator("row", "center", "start")} | ||
gap: 1.4rem; | ||
width: calc(100% + 2.4rem); | ||
padding-right: 2.4rem; | ||
overflow-x: scroll; | ||
|
||
&::-webkit-scrollbar { | ||
display: none; | ||
} | ||
`; | ||
|
||
export const HiddenFileInput = styled.input` | ||
display: none; | ||
`; | ||
|
@@ -135,6 +149,15 @@ export const CustomFileInput = styled.label<{ width?: number; height?: number }> | |
border-radius: 6px; | ||
`; | ||
|
||
export const CustomFileInputCounter = styled.p` | ||
color: ${({ theme }) => theme.colors.gray_500}; | ||
${({ theme }) => theme.fonts["body1-normal-medi"]}; | ||
`; | ||
|
||
export const CustomFileInputLength = styled.span` | ||
color: ${({ theme }) => theme.colors.white}; | ||
`; | ||
|
||
export const PreviewImageWrapper = styled.article<{ width?: number; height?: number }>` | ||
position: relative; | ||
width: ${({ width }) => (width ? width : 10.8)}rem; | ||
Comment on lines
161
to
163
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. p2) 여기 PreviewImageWrapper에도 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 넵 반영하겠습니다! |
||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p2) 여기 CustomFileInput에
flex-shrink: 0
추가해주세요!스크롤 넘어가면 깨지고 있어요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 반영하겠습니다!