[Feat/#361] 공연 수정하기 Step2(스태프&캐스트 리스트) 수정 가능하도록 변경 + 상세 이미지 추가 및 변경 #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
|
imddoy
reviewed
Aug 31, 2024
| @@ -135,6 +149,15 @@ export const CustomFileInput = styled.label<{ width?: number; height?: number }> | |||
| border-radius: 6px; | |||
There was a problem hiding this comment.
p2) 여기 CustomFileInput에 flex-shrink: 0추가해주세요!
스크롤 넘어가면 깨지고 있어요!
Comment on lines
161
to
163
| export const PreviewImageWrapper = styled.article<{ width?: number; height?: number }>` | ||
| position: relative; | ||
| width: ${({ width }) => (width ? width : 10.8)}rem; |
There was a problem hiding this comment.
p2) 여기 PreviewImageWrapper에도 flex-shrink: 0; 추가해주세요!
|
공연 수정은 되는데, 종종 이미지가 안 보이거나, 가격이 안보이거나, 매니저가 바로 적용이 안되거나.. 하는 문제들이 발생하고 있습니다 ㅜㅜ 이 문제들 발생 원인을 아직 잘 모르겠어서, 더 고민해봐야할 것 같습니다 |
|
우선 #380에 코리 내용 전부 반영해뒀습니다 ~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
📸 스크린샷
🔗 참고 자료