-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yeast 8.5.0 #260
yeast 8.5.0 #260
Conversation
travis & memote
as JSON files were too large for the repo
memote 0.8.7 has now the --skip-unchanged flag for this
test_find_incorrect_thermodynamic_reversibility is skipped as it takes more than 10 minutes to run
- eccodes and rxnConfidenceScores are not under 'annotation' - empty references and subsystems should not be written - generated with RAVEN after commit 99a4536b94b07968a7bbebfb39922c76be7f4e1a
chore: update *requirements.txt
feat: memote
- run model=rmfield(model,'subSystems') before running saveYeastModel, until subSystems are added (see #11)
This partially reverts commit 919d396. Restores the model.id so it will not have the dash (so yeastGEM instead of yeast-GEM)
mistakingly reverted in last commit
Benjamin's email no longer active, replace with Eduard's
refactor: standard-GEM
Feat/memote
It should be possible to just change the target branch in this PR without opening a new one? |
Also, is the intention to resolve #11 as part of this release, or would it be better to postpone it? |
I didn't close it manually, but I did just change the name of Re #11, this would take longer to resolve, so probably good to postpone to distribute as 2.5.1? |
Oh, interesting side-effect of branch renaming. |
This seems to be referring to changing name of the default branch, not other branches. Because the "from" branch is renamed, the source is missing and seems like I'll have to remake the PR. Now done as #262. |
Main improvements in this PR:
rxnMiriams
orrxnKEGGpathways
) (PR Chore: update COBRA+RAVEN toolboxes #253)standard-GEM
specifications (PR refactor: standard-GEM #257)master
anddevel
branches tomain
anddevelop
(PR chore: change branch names #261)Also rename your local branches to
main
anddevelop
:PR #261 should first be merged
I hereby confirm that I have:
main
as a target branch (top left drop-down menu)