Add AST support of JSONC (for theme check, language features, etc.) #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
force-pushed
the
fix/654-jsonc-to-ast
branch
from
57db721 to
7d47a8d
Compare
charlespwd
commented
Dec 6, 2024
Comment on lines
+2
to
+47
| export type JSONNodeTypes = 'Object' | 'Array' | 'Property' | 'Identifier' | 'Literal'; | ||
| export type JSONNode = ArrayNode | IdentifierNode | LiteralNode | ObjectNode | PropertyNode; | ||
| export type ValueNode = ObjectNode | ArrayNode | LiteralNode; | ||
|
|
||
| export interface Position { | ||
| offset: number; | ||
| } | ||
|
|
||
| export interface Location { | ||
| start: Position; | ||
| end: Position; | ||
| } | ||
|
|
||
| export interface ASTNode { | ||
| type: string; | ||
| // Modified from @types/json-to-ast make this not-optional | ||
| loc: Location; | ||
| } | ||
|
|
||
| export interface ObjectNode extends ASTNode { | ||
| type: 'Object'; | ||
| children: PropertyNode[]; | ||
| } | ||
|
|
||
| export interface PropertyNode extends ASTNode { | ||
| type: 'Property'; | ||
| key: IdentifierNode; | ||
| value: ValueNode; | ||
| } | ||
|
|
||
| export interface IdentifierNode extends ASTNode { | ||
| type: 'Identifier'; | ||
| value: string; | ||
| raw: string; | ||
| } | ||
|
|
||
| export interface ArrayNode extends ASTNode { | ||
| type: 'Array'; | ||
| children: ValueNode[]; | ||
| } | ||
|
|
||
| export interface LiteralNode extends ASTNode { | ||
| type: 'Literal'; | ||
| value: string | number | boolean | null; | ||
| raw: string; | ||
| } |
There was a problem hiding this comment.
I prefer those types to the ones from jsonc-parser. The ones in jsonc-parser weren't made for discriminated unions and would have made the whole visitor logic not work nice.
The ones from jsonc-parser are here
- Rip out `json-to-ast` - Inline the `json-to-ast` types in `theme-check-common/src/jsonc` - Make a little `jsonc-parser#Node` -> `json-to-ast#ASTNode` adapter Fixes #654
charlespwd
force-pushed
the
fix/654-jsonc-to-ast
branch
from
7d47a8d to
c371b48
Compare
6 tasks
jamesmengo
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
json-to-astjson-to-asttypes intheme-check-common/src/jsoncjsonc-parser#Node->json-to-ast#ASTNodeadapterFixes #654
What did you learn?
AugmentedJSONSourceCodehad aErrorwhenever there was a comment in the JSON fileBefore you deploy
changeset