Add block rename handler (replace old->new everywhere!) #655
+934
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
force-pushed
the
feature/block-rename-handling
branch
from
9b21030 to
15cf74e
Compare
|
Going to try and get the jsonc PR #656 merged as soon as we can here before assessing what kind of assistance we can apply to this PR before CP returns from holiday break. |
Saves you some work to get position info
charlespwd
force-pushed
the
feature/block-rename-handling
branch
2 times, most recently
from
ae65e1f to
f40aba4
Compare
|
I'm picking this back up with Navdeep's first stab at the tests. Couldn't figure out what his email is for the correct co-author to appear on the commit. |
Co-authored-by: Navdeep Singh <[email protected]> Whenever a block gets renamed, the following will now happen: 1. References in files with a {% schema %} will be changed 2. References in template files will be changed 3. References in section groups will be changed 4. References in {% content_for "block", type: "oldName" %} will be changed
charlespwd
force-pushed
the
feature/block-rename-handling
branch
from
f40aba4 to
51fe22e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
When a theme block gets renamed, old references will be workspace edited to the new name in all the following locations:
content_for "block", type: "old-name"templates/*.jsonfilessections/*.jsonfileson-block-rename.mp4
Before you deploy
changeset