ActiveRecord select block returns BasicObject

[jakebrady5]

Motivation

This change matches the block return value to that of the sig on Array#select.

In practice, updating our large Rails app surfaced many violations of this sig that would cause (in my opinion) undesirable code changes in order to satisfy the T::Boolean return type. It does seem quite historically idiomatic for Ruby code to rely on the implicit truthiness/falsiness check, rather than coerce it explicitly.

Implementation

Continuing the original implementation, this is just a change to the return type of the block sig.

Tests

Existing tests are updated to reflect this change and seem to have sufficient coverage.

[paracycle]

Thanks, this makes a lot of sense.

I would have gone for returning T.untyped instead, but I agree that matching the Array#select sig is a better choice.

[jakebrady5]

I was late on the search, but just commenting that another contributor had a similar though differing idea here.

[dirceu]

Awesome, thanks!