Allow Active Record select to return nilable
#2146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #2103 QueryMethods#select: ```ruby > model.features.class => Feature::ActiveRecord_Associations_CollectionProxy > model.features.select { nil } => [] ``` Enumerable#select: ```ruby > a = T.let([1, nil, 3], T::Array[T.nilable(Integer)]) > > T.reveal_type(a) > * a.select do |num| * num.to_c > end => [1, nil, 3] ```
KaanOzkan
approved these changes
Jan 8, 2025
vinistock
approved these changes
Jan 8, 2025
|
I must admit to searching too late, but I just opened a similar PR making a different change to this return value. Just linking so we can connect conversations about the two. ❤️ |
|
Yeah, the behaviour is not just about nilable, but more about how you can return anything from the supplied block, so I think #2147 is the better fix. |
|
Closing in favour of #2147. Please reopen if you disagree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2103; it turns out you can send a nilable to
select.QueryMethods#select:Enumerable#select: