Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less fragile string comparison in negative domain test #17511

Merged
merged 1 commit into from
Feb 5, 2025
Merged

less fragile string comparison in negative domain test #17511

merged 1 commit into from
Feb 5, 2025

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented Feb 5, 2025

Problem Statement

Change in case in error message causes test failure

Solution

this PR

Related Issues

@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Feb 5, 2025
@pondrejk pondrejk self-assigned this Feb 5, 2025
@pondrejk pondrejk requested a review from a team as a code owner February 5, 2025 11:26
@pondrejk
Copy link
Contributor Author

pondrejk commented Feb 5, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_domain.py -k test_negative_create_with_invalid_dns_id

@pondrejk pondrejk changed the title less fragile string comparison in negative host test less fragile string comparison in negative domain test Feb 5, 2025
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10068
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_domain.py -k test_negative_create_with_invalid_dns_id --external-logging
Test Result : ========== 1 passed, 11 deselected, 20 warnings in 669.42s (0:11:09) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 5, 2025
jameerpathan111
jameerpathan111 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@jameerpathan111 jameerpathan111 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting issue and the solution😄

@jameerpathan111 jameerpathan111 merged commit a1de2ba into SatelliteQE:master Feb 5, 2025
15 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
@pondrejk @web-flow
less fragile string comparison in negative domain test (#17511)
29c76c6 
less fragile string comparison in negative host test

(cherry picked from commit a1de2ba)
github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
@pondrejk @web-flow
less fragile string comparison in negative domain test (#17511)
bb503b9 
less fragile string comparison in negative host test

(cherry picked from commit a1de2ba)
github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
@pondrejk @web-flow
less fragile string comparison in negative domain test (#17511)
7582cc7 
less fragile string comparison in negative host test

(cherry picked from commit a1de2ba)
This was referenced Feb 5, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

Assignees

@pondrejk pondrejk

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pondrejk @Satellite-QE @jameerpathan111