Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.16.z] less fragile string comparison in negative domain test #17513

Merged
merged 1 commit into from
Feb 5, 2025
Merged

[6.16.z] less fragile string comparison in negative domain test #17513

merged 1 commit into from
Feb 5, 2025

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #17511

Problem Statement

Change in case in error message causes test failure

Solution

this PR

Related Issues

@pondrejk @web-flow
less fragile string comparison in negative domain test (#17511)
bb503b9 
less fragile string comparison in negative host test

(cherry picked from commit a1de2ba)
@Satellite-QE Satellite-QE added 6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Feb 5, 2025
@Satellite-QE Satellite-QE requested a review from a team as a code owner February 5, 2025 11:56
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_domain.py -k test_negative_create_with_invalid_dns_id

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Feb 5, 2025
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 10071
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_domain.py -k test_negative_create_with_invalid_dns_id --external-logging
Test Result : ========== 1 passed, 11 deselected, 20 warnings in 613.76s (0:10:13) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 5, 2025
@Satellite-QE Satellite-QE merged commit 229c370 into 6.16.z Feb 5, 2025
17 of 18 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.16.z-a1de2baea45bb83dc6ec903e68ac58ef9310b65c branch February 5, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pondrejk pondrejk

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @pondrejk