Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

host should successfully reg with setup_insights=true #16606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

host should successfully reg with setup_insights=true #16606

wants to merge 1 commit into from

Conversation

amolpati30
Copy link
Contributor

@amolpati30 amolpati30 commented Oct 8, 2024 •
edited
Loading

Problem Statement

The global registration method of registration started behaving oddly. The entire process completes but the Host remains in build mode

Solution

Automation: The host has been successfully registered and is no longer in build mode. Additionally, the facts for the host have been processed

@amolpati30 amolpati30 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Oct 8, 2024
@amolpati30 amolpati30 requested a review from a team as a code owner October 8, 2024 06:29
@amolpati30 amolpati30 mentioned this pull request Oct 8, 2024
Closed
@amolpati30 amolpati30 force-pushed the host_reg_with_setup_insight branch 2 times, most recently from ce2afb1 to 4fb3060 Compare October 9, 2024 10:50
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8914
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_registration.py -k test_positive_global_registration_with_setup_insights --external-logging
Test Result : ========== 1 failed, 19 deselected, 34 warnings in 813.27s (0:13:33) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 9, 2024
@amolpati30 amolpati30 marked this pull request as draft October 10, 2024 08:52
@github-actions github-actions bot added the Stale Stale issue or Pull Request label Nov 25, 2024
@github-actions github-actions bot closed this Dec 2, 2024
@amolpati30 amolpati30 reopened this Dec 2, 2024
@github-actions github-actions bot removed the Stale Stale issue or Pull Request label Dec 3, 2024
@amolpati30 amolpati30 force-pushed the host_reg_with_setup_insight branch 2 times, most recently from 5c8c7a7 to 95224ae Compare January 15, 2025 10:48
@amolpati30 amolpati30 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master and removed 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Jan 15, 2025
@amolpati30 amolpati30 marked this pull request as ready for review January 15, 2025 10:59
@amolpati30 amolpati30 force-pushed the host_reg_with_setup_insight branch from 95224ae to 886259b Compare January 15, 2025 11:01
@shweta83
Copy link
Contributor

@amolpati30 Why is it not cherrypicked to older versions? I think the fix is available there too.

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9896
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_registration.py -k test_registering_with_title_using_global_registration_parameter --external-logging
Test Result : ===== 1 passed, 21 deselected, 32 warnings, 1 error in 2297.86s (0:38:17) ======

@amolpati30 amolpati30 force-pushed the host_reg_with_setup_insight branch from d31f192 to b071ca0 Compare January 22, 2025 18:17
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 22, 2025
chris1984
chris1984 reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small change I would make is in the host status, you should see a status for insights, we should assert that is active on the host after registration. That is probably the best way to mock that it did register and went up to the cloud.

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9960
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_registration.py -k test_registering_with_title_using_global_registration_parameter --external-logging
Test Result : ========== 1 passed, 21 deselected, 34 warnings in 808.91s (0:13:28) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 22, 2025
@amolpati30 amolpati30 force-pushed the host_reg_with_setup_insight branch from b071ca0 to 4bd8a2c Compare January 23, 2025 05:12
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 23, 2025
@amolpati30 amolpati30 requested a review from chris1984 January 23, 2025 05:16
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9965
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_registration.py -k test_registering_with_title_using_global_registration_parameter --external-logging
Test Result : ========== 1 passed, 21 deselected, 34 warnings in 873.39s (0:14:33) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 23, 2025
@amolpati30 amolpati30 force-pushed the host_reg_with_setup_insight branch from 4bd8a2c to 1ecad45 Compare January 23, 2025 10:18
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 23, 2025
@amolpati30 amolpati30 force-pushed the host_reg_with_setup_insight branch from 1ecad45 to 9ec0925 Compare January 23, 2025 10:37
@amolpati30 amolpati30 requested a review from shweta83 January 23, 2025 10:38
@amolpati30 amolpati30 force-pushed the host_reg_with_setup_insight branch from 9ec0925 to 39e3225 Compare January 23, 2025 10:48
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9967
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_registration.py -k test_registering_with_title_using_global_registration_parameter --external-logging
Test Result : ========== 1 passed, 21 deselected, 34 warnings in 961.98s (0:16:01) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 23, 2025
@amolpati30 amolpati30 force-pushed the host_reg_with_setup_insight branch from 39e3225 to edc26d5 Compare January 29, 2025 06:52
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 29, 2025
@amolpati30 amolpati30 requested a review from shweta83 January 29, 2025 06:54
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_registration.py -k test_registering_with_title_using_global_registration_parameter

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10005
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_registration.py -k test_registering_with_title_using_global_registration_parameter --external-logging
Test Result : ========== 1 passed, 21 deselected, 34 warnings in 770.54s (0:12:50) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 29, 2025
LadislavVasina1
LadislavVasina1 reviewed Jan 29, 2025
View reviewed changes
tests/foreman/ui/test_registration.py
status = session.host_new.get_host_statuses(rhel_contenthost.hostname)
assert status['Build']['Status'] == 'Installed'
assert status['Insights']['Status'] == 'Reporting'
facts = session.host_new.get_host_facts(rhel_contenthost.hostname, 'insights_client')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use some specific Airgun entity to obtain desired facts and check them afterwards?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can retrieve the required fact using the following:
facts = session.host_new.get_host_facts(rhel_contenthost.hostname, 'insights_client') Additionally, I don't think further filtering is necessary, as this function already provides sufficient information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 Awaiting requested review from chris1984

@shweta83 shweta83 Awaiting requested review from shweta83

@LadislavVasina1 LadislavVasina1 Awaiting requested review from LadislavVasina1

Assignees

@amolpati30 amolpati30

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amolpati30 @Satellite-QE @shweta83 @LadislavVasina1 @chris1984