check facts for host #1591
check facts for host #1591
Conversation
amolpati30
added
CherryPick
| @@ -419,6 +419,15 @@ def get_displayed_table_headers(self): | |||
| view.wait_displayed() | |||
| return view.displayed_table_header_names | |||
|
|
|||
| def build_mode(self, entity_name, value=None): | |||
There was a problem hiding this comment.
Added a method to verify the facts for the host. Can you please more elaborate on the PR description. Also please add some docstring to your entity and maybe alter the entity name so it more reflects what the entity is doing. Thanks!
amolpati30
added
No-CherryPick
amolpati30
force-pushed
the
build_mode_check_facts
branch
from
053fe41 to
a196041
Compare
|
@amolpati30 I can't see you using the airgun entity I coded for you #1589, why didn't you use it? Also leaving commit history would be good review of quarter-old PR. |
|
@LadislavVasina1 |
|
@amolpati30 Didn't you want to read the filled searchbox when you created the PR? I suppose you have edited the description in the meanwhile so it is probable that my addition might be no use to you as it was implement for former PR description and former commit. |
|
@LadislavVasina1 |
|
@amolpati30 There is a method present in airgun to read host facts and you can pass the fact name in robottelo which you want to check. |
|
@shweta83 |
Great! So can we close this PR? |
On the host, it selects the facts and returns the value to verify whether the 'insights_client' is present.
Dependent PR: SatelliteQE/robottelo#16606