Extend sync_status page with active_only support #1708
Merged
+52
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaysawant
approved these changes
Jan 23, 2025
LadislavVasina1
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
PR looks good to me, let's wait for some Robotello PRs testing this addition before merging. Good addition @vsedmik!
Ah, I forgot to update the PR description. The robo PR is up here (with green PRT): SatelliteQE/robottelo#17413 |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
(cherry picked from commit e17a99c)
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is the "Active only" check-box on the sync status page which adjusts the product/repos table to hide the lines where no sync happens. This is done through the
tr'sstyleset todisplay: none, which means the table remains still complete, only the style change hides what needs to be hidden.Unfortunately Airgun does not care about styles and returns the complete table since it's still there in the page.
This PR changes this behaviour to let Airgun return the table just like the user can see it based on the style (via
is_displayedproperty).Second change allows user to set the Active only check-box before read.
Third and last change allows user to sync a repo asynchronously without waiting for result.
Test PR: SatelliteQE/robottelo#17413