Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can set 'ACL_BUILD_THREADS' for parallel build #2679

Merged
merged 2 commits into from
Jun 29, 2020
Merged

User can set 'ACL_BUILD_THREADS' for parallel build #2679

merged 2 commits into from
Jun 29, 2020

Conversation

cgbahk
Copy link
Member

@cgbahk cgbahk commented Jun 26, 2020

This commit introduces ACL_BUILD_THREADS. ACL build will be done by
ACL_BUILD_THREADS number of degree of parallelism.

Note that default behavior, without ACL_BUILD_THREADS specified, is
conserved.

Signed-off-by: Cheongyo Bahk [email protected]


For #2674

@cgbahk cgbahk requested a review from hseok-oh June 26, 2020 08:49
@hseok-oh
Copy link
Contributor

hseok-oh commented Jun 29, 2020

--- a/Makefile.template
+++ b/Makefile.template
@@ -135,6 +135,7 @@ endif
        NNFW_WORKSPACE="$(WORKSPACE)" NNFW_INSTALL_PREFIX=$(INSTALL_PATH) ./nnfw configure \
                -DCMAKE_BUILD_TYPE=$(BUILD_TYPE_LC) \
                -DNNFW_OVERLAY_DIR=$(OVERLAY_FOLDER) \
+               -DACL_BUILD_THREADS=$(NPROCS) \
                $(OPTIONS)
        touch $(TIMESTAMP_CONFIGURE)

It makes CI uses 4-thread build for acl

@cgbahk
Copy link
Member Author

cgbahk commented Jun 29, 2020

@hseok-oh Do you mean you want the patch to be applied to this PR? (I am happy to do that 😄 )

@cgbahk cgbahk closed this Jun 29, 2020
@cgbahk
Copy link
Member Author

cgbahk commented Jun 29, 2020

Oops... I accidently closedㅠㅠ

@cgbahk cgbahk reopened this Jun 29, 2020
@seanshpark
Copy link
Contributor

@nnfw-bot test x64-builder

1 similar comment
@cgbahk
Copy link
Member Author

cgbahk commented Jun 29, 2020

@nnfw-bot test x64-builder

@hseok-oh
Copy link
Contributor

@cgbahk Exactly

cgbahk and others added 2 commits June 29, 2020 12:27
This commit introduces `ACL_BUILD_THREADS`. ACL build will be done by
`ACL_BUILD_THREADS` number of degree of parallelism.

Note that default behavior, without `ACL_BUILD_THREADS` specified, is
conserved.

Signed-off-by: Cheongyo Bahk <[email protected]>
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 0ba3b82 into Samsung:master Jun 29, 2020
@cgbahk cgbahk deleted the PR/acl-build-threads branch June 30, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants