Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci/pass] Fix ExpandBroadcastConstPass #14560

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Jan 16, 2025

Let's fix a bug in ExpandBroadcastConstPass.

ONE-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]


DRAFT: #14555
FOR: #14554

Let's fix a bug in ExpandBroadcastConstPass.

ONE-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
seanshpark
seanshpark previously approved these changes Jan 17, 2025
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark requested a review from jinevening January 17, 2025 04:45
Comment on lines +50 to +55
if (successor->rank() == 1 || successor->rank() > 4)
{
WARN(l) << "NYI: Only 2D/3D/4D tensor broadcast removal is supported";
return nullptr;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanshpark This part is updated. :-D The condition check was done as assert before, but now it returns nullptr.

@dayo09 dayo09 requested a review from seanshpark January 17, 2025 04:55
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinevening jinevening merged commit 66cdc24 into Samsung:master Jan 17, 2025
8 checks passed
chenyx113 pushed a commit to chenyx113/ONE that referenced this pull request Jan 18, 2025
* [luci/pass] Fix ExpandBroadcastConstPass

Let's fix a bug in ExpandBroadcastConstPass.

ONE-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>

* Return nullptr for unsupported case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants