-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[luci/pass] Fix ExpandBroadcastConstPass #14560
Conversation
Let's fix a bug in ExpandBroadcastConstPass. ONE-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if (successor->rank() == 1 || successor->rank() > 4) | ||
{ | ||
WARN(l) << "NYI: Only 2D/3D/4D tensor broadcast removal is supported"; | ||
return nullptr; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanshpark This part is updated. :-D The condition check was done as assert before, but now it returns nullptr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [luci/pass] Fix ExpandBroadcastConstPass Let's fix a bug in ExpandBroadcastConstPass. ONE-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]> * Return nullptr for unsupported case
Let's fix a bug in ExpandBroadcastConstPass.
ONE-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]
DRAFT: #14555
FOR: #14554