Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[luci/pass] Fix ExpandBroadcastConstPass #14555

Closed
wants to merge 2 commits into from
Closed

[luci/pass] Fix ExpandBroadcastConstPass #14555

wants to merge 2 commits into from

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Jan 14, 2025 •
edited
Loading

Let's fix a bug in ExpandBroadcastConstPass.

For #14554

@dayo09 dayo09 force-pushed the 0114-fix-broadcast branch from 8585293 to a1fdd22 Compare January 14, 2025 12:23
@dayo09 dayo09 mentioned this pull request Jan 14, 2025
Closed
@dayo09 dayo09 marked this pull request as ready for review January 15, 2025 04:38
@dayo09 dayo09 requested a review from a team January 15, 2025 04:38
@dayo09 dayo09 requested a review from jinevening January 15, 2025 06:19
@dayo09 dayo09 added DRAFT A draft issue or PR for sharing one's current working status and discussion. and removed DRAFT A draft issue or PR for sharing one's current working status and discussion. labels Jan 16, 2025
@dayo09 dayo09 requested a review from seanshpark January 16, 2025 08:24
@dayo09
Copy link
Contributor Author

dayo09 commented Jan 16, 2025

@jinevening @seanshpark It's ready :-D PTAL

@seanshpark
Copy link
Contributor

please split separate PRs to compiler/* each and others.
for this PR, it would be

  • compiler/luci-pass-value-py-test
  • compiler/luci and
  • res/TensorFlowLiteRecipes

@seanshpark
Copy link
Contributor

I can't deeply understand the algorithm but overall looks OK to me :)

@dayo09 dayo09 added the DRAFT A draft issue or PR for sharing one's current working status and discussion. label Jan 16, 2025
@dayo09
[luci/pass] Fix ExpandBroadcastConstPass
553e048 
Let's fix a bug in ExpandBroadcastConstPass.

ONE-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
@dayo09 dayo09 mentioned this pull request Jan 16, 2025
Merged
@jinevening
Copy link
Contributor

LGTM with minor comment (#14555 (comment)).

Please follow @seanshpark 's direction (#14555 (comment)) because it's the convention of ONE compiler.

@dayo09 dayo09 force-pushed the 0114-fix-broadcast branch from 1f298bb to decffdd Compare January 17, 2025 04:51
@dayo09 dayo09 mentioned this pull request Jan 17, 2025
Merged
@dayo09
Copy link
Contributor Author

dayo09 commented Jan 17, 2025

Done :-D

@dayo09 dayo09 closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinevening jinevening jinevening left review comments

@seanshpark seanshpark seanshpark left review comments

Assignees
No one assigned
Labels
DRAFT A draft issue or PR for sharing one's current working status and discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dayo09 @seanshpark @jinevening