Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for cross-build #14539

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix docs for cross-build #14539

merged 1 commit into from
Jan 14, 2025

Conversation

dahlinPL
Copy link
Contributor

@dahlinPL dahlinPL commented Jan 10, 2025

Small fixes to documentation, based on trying to cross-build to armv7l on Ubuntu 24.04 LTS.

Additionally, as python virtual env is nice to have option, add .venv to .gitignore file.

ONE-DCO-1.0-Signed-off-by: Marcin Słowiński [email protected]

@dahlinPL dahlinPL force-pushed the fix_docs branch 2 times, most recently from de0e27e to 67a47c6 Compare January 10, 2025 16:40
@hseok-oh
Copy link
Contributor

Thanks your first contribution.

Using numpy is same issue on native build (document docs/howto/how-to-build-runtime.md). And there is build requirement section and guide to install numpy by using pip3 install numpy. So we can add guide to use venv into native build document and add link to native build document at first section of arm/aarch64 cross build document.

.gitignore Outdated
Comment on lines 28 to 29
# Python virtualenv
/venv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use /.venv/ directory for python virtualenv.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@hseok-oh
Copy link
Contributor

Please update your 1st commit body to including more than 4 words to pass commit message checker.
I recommend to squash two commits with updating doc diff and commit body.

@dahlinPL dahlinPL force-pushed the fix_docs branch 2 times, most recently from 6ad87f8 to 6bc3e10 Compare January 13, 2025 07:38
@dahlinPL dahlinPL requested a review from hseok-oh January 13, 2025 08:05
This commit introduce some fixes in docs after cross-build
on Ubuntu 24.04. Additionaly Python venv directory was added
into .gitignore file.

ONE-DCO-1.0-Signed-off-by: Marcin Słowiński <[email protected]>
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit b7d4e5e into Samsung:master Jan 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants