-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs for cross-build #14539
Fix docs for cross-build #14539
Conversation
de0e27e
to
67a47c6
Compare
Thanks your first contribution. Using numpy is same issue on native build (document |
.gitignore
Outdated
# Python virtualenv | ||
/venv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to use /.venv/
directory for python virtualenv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Please update your 1st commit body to including more than 4 words to pass commit message checker. |
6ad87f8
to
6bc3e10
Compare
This commit introduce some fixes in docs after cross-build on Ubuntu 24.04. Additionaly Python venv directory was added into .gitignore file. ONE-DCO-1.0-Signed-off-by: Marcin Słowiński <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Small fixes to documentation, based on trying to cross-build to armv7l on Ubuntu 24.04 LTS.
Additionally, as python virtual env is nice to have option, add
.venv
to.gitignore
file.ONE-DCO-1.0-Signed-off-by: Marcin Słowiński [email protected]