[one-optimize] Remove unnecessary Cast Op #13760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds RemoveUnnecessaryCastPass that eliminates Cast nodes which have the same input and output dtype. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
This commit adds an option for RemoveUnnecessaryCastPass. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
This commit adds one-cmd option for RemoveUnnecessaryCastPass. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
This commit adds Net_Unnecessary_Cast tflite recipes. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
This commit adds value tests for RemoveUnnecessaryCastPass. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
This commit is adding circle2circle dredd test for unwanted Cast removal. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
jiwaszki
changed the title
|
@seanshpark @jinevening PR is ready to review. |
jiwaszki
commented
Aug 28, 2024
Comment on lines
479
to
482
| if (_options->query(Options::Algorithm::RemoveUnnecessaryCast)) | ||
| { | ||
| phase.emplace_back(std::make_unique<luci::RemoveUnnecessaryCastPass>()); | ||
| } |
There was a problem hiding this comment.
Note: update with regards to #13800 when it's merged
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM Could you post PRs? |
This commit adds an option for RemoveUnnecessaryCastPass. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
This commit adds RemoveUnnecessaryCastPass that eliminates Cast nodes which have the same input and output dtype. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
This commit adds one-cmd option for RemoveUnnecessaryCastPass. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
This commit adds Net_Unnecessary_Cast tflite recipes. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
This commit adds value tests for RemoveUnnecessaryCastPass. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
This commit is adding circle2circle dredd test for unwanted Cast removal. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
|
@jinevening sure, I have added you as a reviewer in all of them. Also updated this one to align with all of them. |
This was referenced Sep 2, 2024
|
All child PRs has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft that introduces
RemoveUnnecessaryCastPasswhich removesCastoperations with the same input and output types.For issue #13623