Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[circle2circle] Add an option for RemoveUnnecessaryCastPass #13895

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

jiwaszki
Copy link
Contributor

@jiwaszki jiwaszki commented Sep 2, 2024

This commit adds an option for RemoveUnnecessaryCastPass.

ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz [email protected]

This commit adds an option for RemoveUnnecessaryCastPass.

ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
@jiwaszki jiwaszki requested a review from jinevening September 2, 2024 11:29
@jiwaszki
Copy link
Contributor Author

jiwaszki commented Sep 2, 2024

From: #13760
For: #13623

@mhs4670go
Copy link
Contributor

It needs to be rebased as the base commist doesn't have the recipe.

@jiwaszki
Copy link
Contributor Author

jiwaszki commented Sep 3, 2024

@mhs4670go yeah it's waiting for #13893 to be merged.
What is more common practice in the project? Should I split/post it only when all of required parts are merged to master? Or do it like I am doing it now? (Now means that all parts are posted at the "same" time, where some are waiting for others. That gives time to review all of them, check smaller parts without waiting.)

@seanshpark
Copy link
Contributor

What is more common practice in the project?

Good question. I think you're the first to ask this :)
Common is to post one by one for having dependencies and post multiples if not.
But it's OK to post like this and re-base when dependent has landed.

Copy link
Contributor

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinevening jinevening merged commit 552a0e7 into Samsung:master Sep 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants