Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Change core install path #13472

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

hseok-oh
Copy link
Contributor

This commit changes core library install path: lib -> lib/nnfw.
Only API libraries are installed to lib.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]

@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Jul 18, 2024
@hseok-oh hseok-oh requested a review from a team July 18, 2024 07:47
@hseok-oh hseok-oh force-pushed the move_core_install_path branch from 43127b6 to b994f3d Compare July 18, 2024 09:06
ragmani
ragmani previously approved these changes Jul 18, 2024
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jyoungyun
jyoungyun previously approved these changes Jul 21, 2024
@hseok-oh hseok-oh marked this pull request as draft July 22, 2024 04:32
@hseok-oh hseok-oh dismissed stale reviews from jyoungyun and ragmani via f949591 August 28, 2024 10:12
@hseok-oh hseok-oh force-pushed the move_core_install_path branch from b994f3d to f949591 Compare August 28, 2024 10:12
This commit changes core library install path: lib -> lib/nnfw.
Only API libraries are installed to lib.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
@hseok-oh hseok-oh force-pushed the move_core_install_path branch from f949591 to 82a8c45 Compare August 29, 2024 10:12
@hseok-oh hseok-oh marked this pull request as ready for review September 2, 2024 06:47
@hseok-oh
Copy link
Contributor Author

hseok-oh commented Sep 2, 2024

@jyoungyun @ragmani PTAL

@hseok-oh
Copy link
Contributor Author

hseok-oh commented Sep 4, 2024

@jyoungyun PTAL

Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 949661a into Samsung:master Sep 4, 2024
12 checks passed
@hseok-oh hseok-oh deleted the move_core_install_path branch September 4, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants