Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert/android] Update lib path #13962

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

hseok-oh
Copy link
Contributor

@hseok-oh hseok-oh commented Sep 9, 2024

This commit updates core library path for packaging.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]


Path is changed by #13472

This commit updates core library path for packaging.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Sep 9, 2024
@hseok-oh hseok-oh requested a review from a team September 9, 2024 08:49
jyoungyun

This comment was marked as outdated.

Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(question)
Shouldn't we modify the the installation path of libnnfw-dev.so together?

@jyoungyun jyoungyun requested a review from a team September 9, 2024 09:32
@hseok-oh
Copy link
Contributor Author

hseok-oh commented Sep 9, 2024

LGTM

(question) Shouldn't we modify the the installation path of libnnfw-dev.so together?

I didn't modified because it is used by nnstreamer.

Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 6823a1b into Samsung:master Sep 10, 2024
5 checks passed
@hseok-oh hseok-oh deleted the android_core_path branch September 10, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants