Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Add unit tests for training Reshape op #13196

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

ragmani
Copy link
Contributor

@ragmani ragmani commented Jun 14, 2024

This commit adds some tests to validate training of Reshape op.

ONE-DCO-1.0-Signed-off-by: ragmani [email protected]

1, -2, 2, 4, -4, 2, 2, 0, 4, -1, -2, 4}}}, // input dataset
{{{47, -4, -25, 9, 10, 10, -13, 11, -14, -26, -12, 26, 20, 40, 1, 3, 11,
4}}}, // expected dataset
{226.5260f} // last losses
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result of executing the same model with the same data on tensorflow:

Epoch 1/5
1/1 [==============================] - 0s 163ms/step - loss: 403.3333 - categorical_accuracy: 1.0000
Epoch 2/5
1/1 [==============================] - 0s 2ms/step - loss: 324.0978 - categorical_accuracy: 0.0000e+00 
Epoch 3/5 
1/1 [==============================] - 0s 2ms/step - loss: 267.7882 - categorical_accuracy: 0.0000e+00 
Epoch 4/5 
1/1 [==============================] - 0s 2ms/step - loss: 226.5260 - categorical_accuracy: 0.0000e+00 
Epoch 5/5 
1/1 [==============================] - 0s 2ms/step - loss: 195.3313 - categorical_accuracy: 0.0000e+00

@ragmani ragmani requested a review from a team June 14, 2024 08:09
@ragmani ragmani added the PR/ready for review It is ready to review. Please review it. label Jun 14, 2024
@ragmani
Copy link
Contributor Author

ragmani commented Jun 17, 2024

@nnfw-bot test onert-x64-release

@ragmani ragmani added PR/NO MERGE Please don't merge. I'm still working on this :) and removed PR/ready for review It is ready to review. Please review it. labels Jun 17, 2024
ragmani added 2 commits June 17, 2024 19:40
This commit adds some tests to validate training of Reshape op.

ONE-DCO-1.0-Signed-off-by: ragmani <[email protected]>
@ragmani ragmani force-pushed the onert/reshape_training_test branch from 772dd6c to 4955eba Compare June 17, 2024 10:43
@ragmani
Copy link
Contributor Author

ragmani commented Jun 17, 2024

Added cgen.markAllOpsAsTrainable();

@ragmani ragmani added PR/ready for review It is ready to review. Please review it. and removed PR/NO MERGE Please don't merge. I'm still working on this :) labels Jun 17, 2024
Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hseok-oh hseok-oh merged commit 56c79b7 into Samsung:master Jun 19, 2024
9 checks passed
@ragmani ragmani deleted the onert/reshape_training_test branch July 3, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants