Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cker] Introduce ReLU6 gradient kernel #12476

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

zetwhite
Copy link
Contributor

@zetwhite zetwhite commented Jan 15, 2024

This PR introduces ReLU6 gradient kernel.

issue : #12388
draft : #12395

ONE-DCO-1.0-Signed-off-by: SeungHui Youn [email protected]

This PR introduces ReLU6 gradient kernel.

ONE-DCO-1.0-Signed-off-by: SeungHui Youn <[email protected]>
Relu6OpVerifier<float> verifier;

// clang-format off
// std::vector<float> input_fwd = {-2.0, -1.0, 2.0, 3.0, 6.0, 7.0};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input_fwd is just for reference.
I thought with the input of forwarding, understanding the test case is much easier :)

@zetwhite zetwhite added approval: 2 Require at least 2 approvals PR/ready for review It is ready to review. Please review it. labels Jan 15, 2024
@zetwhite zetwhite requested a review from a team January 15, 2024 08:30
@zetwhite zetwhite added PR/NO MERGE Please don't merge. I'm still working on this :) and removed PR/ready for review It is ready to review. Please review it. labels Jan 16, 2024
@zetwhite

This comment was marked as resolved.

@zetwhite
Copy link
Contributor Author

PTAL, Thank you in advance.

Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zetwhite zetwhite added PR/ready for review It is ready to review. Please review it. and removed PR/NO MERGE Please don't merge. I'm still working on this :) labels Jan 17, 2024
Copy link
Contributor

@YongseopKim YongseopKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glistening glistening merged commit 2a4d8d6 into Samsung:master Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: 2 Require at least 2 approvals PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants