Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CircleGraph] Introduce 'scrollToSelected' message #1546

Merged
merged 1 commit into from
May 2, 2023
Merged

[CircleGraph] Introduce 'scrollToSelected' message #1546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CircleGraph/CircleGraphCtrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export class MessageDefs {
public static readonly backendColor = "backendColor";
public static readonly error = "error";
public static readonly colorTheme = "colorTheme";
public static readonly scrollToSelected = "scrollToSelected";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot accept this change and with related changes from the draft.
I need to test other modules with your change in the draft but cannot do the test as I am busy with other works and I cannot say when.

If possible, please do not fix this module but fix your codes.
If not, please post a new issue what you want, what the problem is with current codes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanshpark
I see. Thank you. ok.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed your draft code and there's no modification to existing features so I think it's OK to land the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh. ok. Thank you!

// loadmodel type
public static readonly modelpath = "modelpath";
public static readonly uint8array = "uint8array";
Expand Down