-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUM-253 | add heading size option #66
Changes from 14 commits
d5bda52
ec9c27e
2c1555c
a7c62d3
e866163
81ae830
4411fb8
5e71850
04eef09
32df007
75b0f23
91f4011
0e975db
fbf101d
0d468b7
08325f9
3927607
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,9 +66,11 @@ const PillCard = ({imageUrl, imageAlt, videoUrl, isArticle, children, bgColor, . | |
|
||
<div | ||
className={twMerge( | ||
"rs-px-3 flex flex-col pb-[125px] pt-20 @7xl:rs-px-4 @2xl:pb-[175px] @3xl:pb-[225px] @4xl:pb-[300px]", | ||
"rs-px-3 flex flex-col pb-[125px] pt-20 @7xl:rs-px-4 @2xl:pb-[175px] @3xl:pb-[225px] @4xl:pb-[300px] [&_p>a]:text-black-true hocus:[&_p>a]:text-[#00365C]", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Slipping in the accessibility color change as well 🤔 Does this darker digital blue color change work for the hover/focus state? https://webaim.org/resources/contrastchecker/?fcolor=00365C&bcolor=F9A44A There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like it does, but the links on the "Spirited Light" (2.46) and the "Olive Light" (2.86) still don't work |
||
clsx({ | ||
"pt-[125px] @3xl:pt-[175px] @4xl:pt-[225px] @5xl:pt-[250px] @7xl:pt-[300px]": !imageUrl, | ||
"[&_p>a]:text-digital-blue hocus:[&_p>a]:text-black": | ||
typeof bgColor == "string" && bgColor?.includes("semitransparent"), | ||
}) | ||
)} | ||
> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import {extendTailwindMerge} from "tailwind-merge" | ||
|
||
// Creates an array containing type-# classes from 0 to 1 | ||
const typeClasses = Array.from({length: 10}, (_, i) => `type-${i}`) | ||
// Creates an array containing text-# classes from 11 to 30 | ||
const textClasses = Array.from({length: 20}, (_, i) => `text-${i + 11}`) | ||
|
||
const typographyClasses = [...textClasses, ...typeClasses] | ||
|
||
const twMerge = extendTailwindMerge({ | ||
extend: { | ||
classGroups: { | ||
"font-size": typographyClasses, | ||
}, | ||
}, | ||
}) | ||
|
||
export default twMerge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is greatly increasing complexity, I think we advise against this in the future.