-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUM-253 | add heading size option #66
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d5bda52
SUM-253 | add heading size option
rebeccahongsf ec9c27e
remove unnecessary default option
rebeccahongsf 2c1555c
remove default, add headings
rebeccahongsf a7c62d3
correct type
rebeccahongsf e866163
remove unnecessary default check
rebeccahongsf 81ae830
simplify conditional
rebeccahongsf 4411fb8
SUM-253 | customTwMerge (#67)
rebeccahongsf 5e71850
fixup lint; adjust to use clsx
rebeccahongsf 04eef09
Merge branch '1.x' into feature/SUM-253--headingSize
rebeccahongsf 32df007
remove empty string return
rebeccahongsf 75b0f23
return heading type size
rebeccahongsf 91f4011
replace string with undefined
rebeccahongsf 0e975db
SUM-269 | adjust links for dark pill color backgrounds
rebeccahongsf fbf101d
adjust conditional
rebeccahongsf 0d468b7
remove unecessary conditional
rebeccahongsf 08325f9
change to an accessible blue
rebeccahongsf 3927607
Merge branch '1.x' into feature/SUM-253--headingSize
pookmish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import {extendTailwindMerge} from "tailwind-merge" | ||
|
||
// Creates an array containing type-# classes from 0 to 1 | ||
const typeClasses = Array.from({length: 10}, (_, i) => `type-${i}`) | ||
// Creates an array containing text-# classes from 11 to 30 | ||
const textClasses = Array.from({length: 20}, (_, i) => `text-${i + 11}`) | ||
|
||
const typographyClasses = [...textClasses, ...typeClasses] | ||
|
||
const twMerge = extendTailwindMerge({ | ||
extend: { | ||
classGroups: { | ||
"font-size": typographyClasses, | ||
}, | ||
}, | ||
}) | ||
|
||
export default twMerge |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is greatly increasing complexity, I think we advise against this in the future.