Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed generator and parser to use some of the types directly #104

Merged
merged 4 commits into from
Dec 6, 2023
Merged

fix: fixed generator and parser to use some of the types directly #104

merged 4 commits into from
Dec 6, 2023

Conversation

g-cheishvili
Copy link
Contributor

@g-cheishvili g-cheishvili requested review from ilhan007 and a team December 5, 2023 13:17
@g-cheishvili g-cheishvili added enhancement New feature or request tooling tooling and CI related activities ui5 webC api.json parser Topic related to the api.json parser Angular generator Topic related to the Angular Generator labels Dec 5, 2023
@g-cheishvili g-cheishvili mentioned this pull request Dec 5, 2023
Merged
@g-cheishvili g-cheishvili merged commit 2cfdd57 into feat-update-to-webc-1.20.0 Dec 6, 2023
3 checks passed
@g-cheishvili g-cheishvili deleted the feat-update-to-webc-1.20.0-with-fixes branch December 6, 2023 08:45
ilhan007 added a commit that referenced this pull request Dec 6, 2023
@ilhan007 @g-cheishvili
feat: update to ui5-webcomponents 1.20.0 (#103)
b458553 
* feat: update to ui5-webcomponents 1.20.0

- Select web component has new property "value" that should fix FormControl issues as the Select ngx wrapper relies on setting/getting value
SAP/ui5-webcomponents#7865

- TextArea and StepInput now provide @formEvents, @formProperty so that respective ngx wrappers are extending the GenericControlValueAccessor and thus support FormControl properly
SAP/ui5-webcomponents#7859

* fix: fixed generator and parser to use some of the types directly (#104)

* fix: fixed component parsing and generation

* fix: using only public methods

* fix: updated snapshots

* chore: updated snapshots

---------

Co-authored-by: Giorgi Cheishvili <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
Angular generator Topic related to the Angular Generator api.json parser Topic related to the api.json parser enhancement New feature or request tooling tooling and CI related activities ui5 webC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-cheishvili @ilhan007