feat: update to ui5-webcomponents 1.20.0 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Select web component has new property "value" that should fix FormControl issues as the Select ngx wrapper relies on setting/getting value SAP/ui5-webcomponents#7865 - TextArea and StepInput now provide @formEvents, @formProperty so that respective ngx wrappers are extending the GenericControlValueAccessor and thus support FormControl properly SAP/ui5-webcomponents#7859
✅ Deploy Preview for ui5-webcomponents-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
|
Side navigation output type is broken, it contains multiple same items in the enum and it also contains |
|
Issues are fixed with #104 |
* fix: fixed component parsing and generation * fix: using only public methods * fix: updated snapshots * chore: updated snapshots
g-cheishvili
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the dependency to latest ui5-webcomponents 1.20.0
Notable changes that concerns Reactive Forms support:
valueproperty ui5-webcomponents#7865