Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: No FormControl support #93

Closed
1 of 4 tasks
ilhan007 opened this issue Nov 1, 2023 · 3 comments · Fixed by #112
Closed
1 of 4 tasks

Select: No FormControl support #93

ilhan007 opened this issue Nov 1, 2023 · 3 comments · Fixed by #112
Assignees
Labels
Angular generator Topic related to the Angular Generator bug Something isn't working SAP Build Process Automation
Milestone

Comments

@ilhan007
Copy link
Member

ilhan007 commented Nov 1, 2023

Created the issue on behalf of SAP Build Process Automation:
Select - FormControl support is missing.

Expected Behavior

Steps to Reproduce

  1. Go to '...'
  2. ...
  3. ...

Isolated Example

Context

  • UI5 Web Components version: {...}
  • UI5 Web Components for Angular version: {...}
  • Angular Version: {...}
  • OS/Platform: {...}
  • Browser: {...}
  • Affected component: {...}

Log Output / Stack Trace / Screenshots

{...}

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: {...}
  • Business impact: {...}
@ilhan007
Copy link
Member Author

ilhan007 commented Nov 1, 2023

Hello @droshev this is one of the latest issues raised. Meanwhile I will ask the authors for more information. Thank you.

@ilhan007 ilhan007 added the bug Something isn't working label Nov 1, 2023
@timogeib
Copy link

timogeib commented Nov 8, 2023

FormControl not working at all -> No value accessor for form control error in console
image
image

@droshev droshev added this to the Sprint 127 milestone Nov 22, 2023
@g-cheishvili g-cheishvili added the Angular generator Topic related to the Angular Generator label Nov 23, 2023
@ilhan007
Copy link
Member Author

ilhan007 commented Dec 5, 2023

Hello @mikerodonnell89 @g-cheishvili

The FormControl support of the Select directive should be fixed if you update the ui5-webcomponents-ngx wrappers to the latest ui5-webcomponents as in the latest version we introduced a "value" property to the Select web component (that is marked as formProperty), so that the generated wrapper will extend GVA and the default setters and getters that rely on having a "value" property will work as we added "value" property to the Select web component

Actually I tried to update but there are some build issues to fix:
#103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment