feat: ROS2 High level generic API #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachwalk
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Thank you for doing this, the ROS connector will provide a lot of valuable functionality. I left a few comments regarding configurability and tests. The most importand change requested is adding the cleanup function to the base class, I think it would be very valuable to have all connectors provide an explicit cleanup.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
maciejmajek
commented
Jan 13, 2025
maciejmajek
commented
Jan 13, 2025
2 tasks
…e related ROS 2 Node code inside relevant test cases
…Node class into test code
maciejmajek
force-pushed
the
feat/std-connectors
branch
from
f8f22e6 to
4c238e5
Compare
Co-authored-by: Bartłomiej Boczek <[email protected]>
maciejmajek
force-pushed
the
feat/std-connectors
branch
from
1fdbb28 to
581aef3
Compare
maciejmajek
changed the title
|
Closed in favor of #367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR has been repurposed from introducing standard connector to providing High level generic ROS 2 API
Purpose
This PR aims to provide a unified ROS2 High level API for general use across the framework.
Proposed changes
TBD
Details
Purpose
At the moment, there is little to no actual SDK in RAI. This PR is one of many upcoming changes aimed at introducing a new BaseAgent and BaseConnector architecture. These changes are designed to make RAI easily extendable across various environments, based on specific needs.
Proposed Changes
A connector closely aligned with the ROS 2 architecture. It serves as a lightweight layer between RAI and ROS 2, enabling the integration of additional connectors while maintaining a unified input-output architecture.
- HTTPConnectorA simple connector demonstrating how easily data can be published to external destinations (e.g., web interfaces, displays, etc.).
Testing
TBD
TODO: