-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hub shortcode #3084
feat: add hub shortcode #3084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been holding off reviewing this because of the conflict. Did you want to try to get this in?
No chance I'll be able to get this in before tomorrow's release. Let's hold off on it until the subsequent one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this wasn't a one-time command, I'd recommend pursuing the timestamps=false
route. Really confused why it wasn't working.
Related to #3065 and should likely deploy simultaneously.
This PR adds a
[hub=N]
shortcode for both the forums and messages, as well as an Artisan command to migrate legacy hub game shortcodes to the new[hub]
shortcode.How to test this PR:
This will convert all existing legacy hub game shortcodes to the new hub shortcode.
You can also roll it back with:
This command is largely based on the one we used for user IDs.
Now, you should be able to check any forum topic that uses a hub shortcode, ie: http://localhost:64000/viewtopic.php?t=1287.
You can also try using and previewing the hub shortcode directly with something like
[hub=1]
.Currently, the new hub shortcodes look and feel exactly like the existing legacy game shortcodes.