Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hub shortcode #3084

Merged
merged 9 commits into from
Jan 26, 2025

Conversation

wescopeland
Copy link
Member

Related to #3065 and should likely deploy simultaneously.

This PR adds a [hub=N] shortcode for both the forums and messages, as well as an Artisan command to migrate legacy hub game shortcodes to the new [hub] shortcode.

How to test this PR:

sail artisan ra:community:migrate-game-shortcodes

This will convert all existing legacy hub game shortcodes to the new hub shortcode.
You can also roll it back with:

sail artisan ra:community:migrate-game-shortcodes --undo

This command is largely based on the one we used for user IDs.

Now, you should be able to check any forum topic that uses a hub shortcode, ie: http://localhost:64000/viewtopic.php?t=1287.

You can also try using and previewing the hub shortcode directly with something like [hub=1].

Currently, the new hub shortcodes look and feel exactly like the existing legacy game shortcodes.

Screenshot 2025-01-19 at 6 29 42 PM

Screenshot 2025-01-19 at 6 29 54 PM

@wescopeland wescopeland requested a review from a team January 19, 2025 23:30
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been holding off reviewing this because of the conflict. Did you want to try to get this in?

app/Community/Commands/ConvertGameShortcodesToHubs.php Outdated Show resolved Hide resolved
@wescopeland
Copy link
Member Author

No chance I'll be able to get this in before tomorrow's release. Let's hold off on it until the subsequent one.

Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this wasn't a one-time command, I'd recommend pursuing the timestamps=false route. Really confused why it wasn't working.

@wescopeland wescopeland added the deployment/command Includes an Artisan command that needs to be run before/during deployment label Jan 26, 2025
@wescopeland wescopeland merged commit 40a70de into RetroAchievements:master Jan 26, 2025
8 checks passed
@wescopeland wescopeland deleted the hub-shortcode branch January 26, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment/command Includes an Artisan command that needs to be run before/during deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants