feat(hub): allow some roles to create new hubs #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
approved these changes
Jan 28, 2025
| Role::ADMINISTRATOR, | ||
| Role::GAME_HASH_MANAGER, | ||
| Role::GAME_EDITOR, | ||
| ]); |
There was a problem hiding this comment.
I'm not sure if we should have a separate role, or if this should be opened more.
I know we have hubs dedicated to events, and there's all the Meta|** hubs that are used by other teams.
There was a problem hiding this comment.
I'm not too sure either. I don't think this should be opened up to events managers or the 3 staff dev roles. Right now I'm inclined to think if any of those folks regularly find themselves creating new hubs, they should be given the game editor role, otherwise they can ask one of these 3 roles who are ultimately responsible for the curation of the hubs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3065 and #3084.
Allows admins, game hash managers, and game editors to create new hubs.