-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shortcode support for [quote] #3074
shortcode support for [quote] #3074
Conversation
I was hoping to pick this off, it seems you beat me to it :-) For quote support, I think something like this is desirable:
This allows us to standardize authorship and linkbacks in a dedicated "quote" button on posts. In other words, if I want to quote a post, I will click a new "quote" button on the post itself, which starts a post creation flow with these values pre-filled. I don't think we should support that interaction right now, as I'm in the process of migrating the forum to Filament, but we should at least support |
Correct me if I'm wrong, but do any of the existing tags support properties? Everything is either I would expect those extra properties would be optional, as the user might want to quote a source that's not another forum post. |
You're correct - none of them do. You make a good point. Given that those values should be optional, we can add them later. |
resources/js/features/forums/components/ShortcodeRenderer/ShortcodeQuote/ShortcodeQuote.tsx
Show resolved
Hide resolved
resources/js/features/forums/components/ShortcodeRenderer/ShortcodeQuote/ShortcodeQuote.tsx
Outdated
Show resolved
Hide resolved
Sorry, not sure why this was closed. I think GitHub did it automatically? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poked around a bit with the latest changes. I think things are looking good now 👍
Provides a separate [quote] shortcode tag, so the user doesn't have to use [code] or [i] as a substitute.
Before:
After:
Nested formatting example (though copying text to use in a quote won't copy the formatting tags):
There are already a few examples of people trying to use it in the database. Was it maybe sort of supported at some point in the past?