Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortcode support for [quote] #3074

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Jan 18, 2025

Provides a separate [quote] shortcode tag, so the user doesn't have to use [code] or [i] as a substitute.

Before:
image

After:
image

Nested formatting example (though copying text to use in a quote won't copy the formatting tags):
image

There are already a few examples of people trying to use it in the database. Was it maybe sort of supported at some point in the past?

@wescopeland
Copy link
Member

wescopeland commented Jan 18, 2025

I was hoping to pick this off, it seems you beat me to it :-)

For quote support, I think something like this is desirable:

[quote author={user_display_name} comment={forum-topic-comment-id}]
this is the quote
[/quote]

This allows us to standardize authorship and linkbacks in a dedicated "quote" button on posts. In other words, if I want to quote a post, I will click a new "quote" button on the post itself, which starts a post creation flow with these values pre-filled. I don't think we should support that interaction right now, as I'm in the process of migrating the forum to Filament, but we should at least support author and probably comment props in the shortcode.

@Jamiras
Copy link
Member Author

Jamiras commented Jan 18, 2025

Correct me if I'm wrong, but do any of the existing tags support properties? Everything is either [tag]content[/tag] or [tag=value]content[/tag].

I would expect those extra properties would be optional, as the user might want to quote a source that's not another forum post.

@wescopeland
Copy link
Member

You're correct - none of them do. You make a good point.

Given that those values should be optional, we can add them later.

@Jamiras Jamiras reopened this Jan 20, 2025
@wescopeland
Copy link
Member

Sorry, not sure why this was closed. I think GitHub did it automatically?

@Jamiras
Copy link
Member Author

Jamiras commented Jan 20, 2025

Yep.

Closed by 3083
image

Which says it resolves a comment here.
image

Surprised it did it for a comment reference though.

Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poked around a bit with the latest changes. I think things are looking good now 👍

@Jamiras Jamiras merged commit bc9db6e into RetroAchievements:master Jan 20, 2025
8 checks passed
@Jamiras Jamiras deleted the feature/forum_quote branch January 20, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants