fix(forums): normalize newlines from synthetic events #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
approved these changes
Jan 20, 2025
| } | ||
|
|
||
| return <span className="codetags">{children}</span>; | ||
| return <span className="codetags mb-3 font-mono">{children}</span>; |
| @@ -30,7 +30,11 @@ const createPatterns = (type: string) => [ | |||
| ]; | |||
|
|
|||
| export function preProcessShortcodesInBody(body: string): string { | |||
| let result = body; | |||
| // First, normalize any escaped newlines back to actual newlines. | |||
| let result = body.replace(/↵\n/g, '\n'); | |||
There was a problem hiding this comment.
A unicode character for escaping a newline? I've never seen that before.
Should you use an escape sequence for it (\u21B5) to prevent possible encoding issues?
There was a problem hiding this comment.
No harm in adding an escape sequence. Updated in latest - I'll go ahead and merge so the changes in this branch can safely land in #3074.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3074 (comment).
Also, adds margin bottom to code tags (we should probably also apply the same margin bottom to quote tags).
Root Cause
React uses its own synthetic event system to maximize browser compatibility. For example, when a component has
onClick={(event) => {...}}, this is not a nativeonclick="..."event. It's running through React's synthetic event system that emulates native events.I've worked with React for a number of years and haven't hit a bug caused by synthetic events until now.
In our case, newlines were being sent to the preview component as escaped sequences (↵\n) after making any edit (ie: when initiating a synthetic event), but are served as actual newlines (\n) on load. I was able to observe this after putting a ton of logging in all the BBCode processors.
This fix normalizes all line endings to actual newlines (\n) during the preprocessing stage, ensuring consistent handling of whitespace regardless of how the newlines are represented in the input.