feat: add built-in recommeded-strict ruleset #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 87fd36a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage report
Show new covered files 🐣
Test suite run success646 tests passing in 93 suites. Report generated by 🧪jest coverage report action from 87fd36a |
tatomyr
changed the title
lornajane
reviewed
Oct 25, 2023
lornajane
approved these changes
Oct 25, 2023
SmoliyY
approved these changes
Oct 25, 2023
Co-authored-by: Lorna Jane Mitchell <[email protected]>
tatomyr
force-pushed
the
feat/add-recommended-strict-ruleset
branch
from
1f9f5cd to
87fd36a
Compare
jerryshao
pushed a commit
to apache/gravitino
that referenced
this pull request
Feb 2, 2024
…1899) ### What changes were proposed in this pull request? treat warnings as errors in lint OpenAPI ### Why are the changes needed? Fix: #1893 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? about `recommended-strict`, see [here](Redocly/redocly-cli#1311) before: <img width="1417" alt="image" src="https://github.com/datastrato/gravitino/assets/24897598/e610696b-76ff-4d80-8c25-a13d11fdde8c"> after: <img width="1415" alt="image" src="https://github.com/datastrato/gravitino/assets/24897598/b7f0aec8-70b6-48ab-9d3c-45dc74f52a9c">
github-actions bot
pushed a commit
to apache/gravitino
that referenced
this pull request
Feb 2, 2024
…1899) ### What changes were proposed in this pull request? treat warnings as errors in lint OpenAPI ### Why are the changes needed? Fix: #1893 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? about `recommended-strict`, see [here](Redocly/redocly-cli#1311) before: <img width="1417" alt="image" src="https://github.com/datastrato/gravitino/assets/24897598/e610696b-76ff-4d80-8c25-a13d11fdde8c"> after: <img width="1415" alt="image" src="https://github.com/datastrato/gravitino/assets/24897598/b7f0aec8-70b6-48ab-9d3c-45dc74f52a9c">
mchades
added a commit
to apache/gravitino
that referenced
this pull request
Feb 2, 2024
…1905) ### What changes were proposed in this pull request? treat warnings as errors in lint OpenAPI ### Why are the changes needed? Fix: #1893 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? about `recommended-strict`, see [here](Redocly/redocly-cli#1311) before: <img width="1417" alt="image" src="https://github.com/datastrato/gravitino/assets/24897598/e610696b-76ff-4d80-8c25-a13d11fdde8c"> after: <img width="1415" alt="image" src="https://github.com/datastrato/gravitino/assets/24897598/b7f0aec8-70b6-48ab-9d3c-45dc74f52a9c"> Co-authored-by: mchades <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Adding new
recommended-strictruleset (the same asrecommended, but with errors instead of warnings), so users rely on a maintained strict ruleset.Also fixed a couple of discrepancies while updating tests/docs.
Reference
Closes #1290
Also related to:
#747
#976
#1277
Testing
Screenshots (optional)
Check yourself
Security