Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1893] improvement(build): treat warnings as errors in lint OpenAPI #1905

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

treat warnings as errors in lint OpenAPI

Why are the changes needed?

Fix: #1893

Does this PR introduce any user-facing change?

no

How was this patch tested?

about recommended-strict, see here

before:

image

after:

image

…1899)

### What changes were proposed in this pull request?

treat warnings as errors in lint OpenAPI

### Why are the changes needed?

Fix: #1893

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?
about `recommended-strict`, see
[here](Redocly/redocly-cli#1311)

before:

<img width="1417" alt="image"
src="https://github.com/datastrato/gravitino/assets/24897598/e610696b-76ff-4d80-8c25-a13d11fdde8c">

after:

<img width="1415" alt="image"
src="https://github.com/datastrato/gravitino/assets/24897598/b7f0aec8-70b6-48ab-9d3c-45dc74f52a9c">
@mchades mchades merged commit 56530c2 into branch-0.4 Feb 2, 2024
5 checks passed
@mchades mchades deleted the cherry-pick-branch-0.4-2b5f47662aa8c800c66cfa5674fb47bdffeafd80 branch February 2, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants