Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyval test Assertion Error Fix #67

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Polyval test Assertion Error Fix #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3c472fd
Changing polyval test tolerance for Assertion error and reverting PR #63
shbiswas834 Nov 1, 2024
d102ee6
removed comments
shbiswas834 Nov 1, 2024
bfd707c
removed header
shbiswas834 Nov 1, 2024
34ec802
Added check for rocm on tolerance change
Nov 5, 2024
b9a2647
fix static check
shbiswas834 Nov 6, 2024
9c6dff7
fix static check autopep8
shbiswas834 Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 2 additions & 21 deletions cupy/testing/_loops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
from cupy.testing import _parameterized
import cupyx
import cupyx.scipy.sparse
from cupy_backends.cuda.api import runtime

from cupy.testing._pytest_impl import is_available

Expand Down Expand Up @@ -511,26 +510,8 @@ def numpy_cupy_allclose(rtol=1e-7, atol=0, err_msg='', verbose=True,

def check_func(c, n):
rtol1, atol1 = _resolve_tolerance(type_check, c, rtol, atol)
try:
_array.assert_allclose(c, n, rtol1, atol1, err_msg, verbose)
except AssertionError as e:
import numbers
if runtime.is_hip and type(n) is numpy.ndarray and \
(issubclass(n.dtype.type, numbers.Real) or
issubclass(n.dtype.type, numbers.Complex)):
npc = cupy.asnumpy(c)
diff = numpy.linalg.norm(npc - n, numpy.inf)
norm = numpy.linalg.norm(npc, numpy.inf)
if numpy.any(npc) and numpy.any(n):
min_positive = numpy.finfo(n.dtype).tiny
if (abs(npc) < min_positive).any() or \
(abs(n) < min_positive).any():
# Denormal case handling
assert diff <= (atol1 + rtol1 * norm)
else:
raise e
else:
raise e
_array.assert_allclose(c, n, rtol1, atol1, err_msg, verbose)

return _make_decorator(check_func, name, type_check, contiguous_check,
accept_error, sp_name, scipy_name,
_check_sparse_format)
Expand Down
9 changes: 8 additions & 1 deletion tests/cupy_tests/lib_tests/test_polynomial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from cupy.cuda import runtime
import cupyx
from cupy import testing
from cupy_backends.cuda.api import runtime as _runtime


@testing.parameterize(
Expand Down Expand Up @@ -694,7 +695,13 @@ def test_polyfit_weighted_diff_types(self, xp, dtype1, dtype2, dtype3):
class TestPolyval(Poly1dTestBase):

@testing.for_all_dtypes()
@testing.numpy_cupy_allclose(rtol={numpy.float16: 1e-2, 'default': 1e-3})
@testing.numpy_cupy_allclose(
rtol=(
{numpy.float16: 1e-2, 'default': 2e-3}
if _runtime.is_hip
else {numpy.float16: 1e-2, 'default': 1e-3}
)
)
def test_polyval(self, xp, dtype):
a1 = self._get_input(xp, self.type_l, dtype, size=5)
a2 = self._get_input(xp, self.type_r, dtype, size=5)
Expand Down
Loading