Polyval test Assertion Error Fix #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcskrishna
approved these changes
Nov 1, 2024
pnunna93
requested changes
Nov 1, 2024
There was a problem hiding this comment.
@shbiswas834 the PR is changing file permissions, please revert them and add condition for rocm as mentioned below.
| @@ -694,7 +694,7 @@ def test_polyfit_weighted_diff_types(self, xp, dtype1, dtype2, dtype3): | |||
| class TestPolyval(Poly1dTestBase): | |||
|
|
|||
| @testing.for_all_dtypes() | |||
| @testing.numpy_cupy_allclose(rtol={numpy.float16: 1e-2, 'default': 1e-3}) | |||
| @testing.numpy_cupy_allclose(rtol={numpy.float16: 1e-2, 'default': 2e-3}) | |||
There was a problem hiding this comment.
This changes tolerance for both rocm and cuda, please add a conditional check for rocm. You can use runtime.is_hip to check the platform.
There was a problem hiding this comment.
Hey @pnunna93 Added this check. UT passes
ut_lib.log
There was a problem hiding this comment.
Thanks, please fix file permissions and static checks.
shbiswas834
force-pushed
the
shreya/polyval_tolarance
branch
2 times, most recently
from
4052fa4 to
e3dbff1
Compare
shbiswas834
force-pushed
the
shreya/polyval_tolarance
branch
from
e3dbff1 to
9c6dff7
Compare
lcskrishna
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
tests/cupy_tests/lib_tests - TestPolyval::test_polyval - AssertionErrorcheck_funcfrom PR 63cupy_unit_tests_pr_revert.log