Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipaPy2 PR #629
base: master
Are you sure you want to change the base?
ipaPy2 PR #629
Changes from 32 commits
a338bbc
f95e14a
4982aba
8990fcf
2e6e58f
3c28584
357a3e5
8286e5a
c5a98a0
d9b87e9
9705593
8c5bafd
a7f5ff8
c217fe1
94af151
76dc71a
04166cd
651874d
5e4d5e9
895aee6
a37e307
f28a256
f539a24
fc7b6e0
b088e09
3fabee0
cf93eb6
822ee55
67f7cfe
2c265d3
c8bb50e
6e41fbf
5be1b0d
77a0c8b
4cfdafd
b3b9e04
fe475ce
40f4207
5411edf
0694a63
d806e37
96b7fb8
c978d8b
fc5625d
a8c80e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as for the previous wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented this in the XML wrapper. I did this based on the idea that a function should be self-contained and not depend too much on external conditions. Thus, the .py file exposes some functionality to the. XML file.
I did not want to assume that said parameter will be set in the .XML, even though the check is done there as well.