Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipaPy2 PR #629

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

ipaPy2 PR #629

wants to merge 44 commits into from

Conversation

acquayefrank
Copy link

Describe your changes

Finished the ipaPy2 integration for galaxytools

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added thorough tests to see if it is a core feature.

Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would overall be nice to improve still the parameters and to re-use more code where possible. Another thing would be to add different input formats and standardize the outputs to be "tabular" files (=tsv), as I think this is the recommended tabular file format.

tools/ipapy2/.shed.yml Outdated Show resolved Hide resolved
tools/ipapy2/ipapy2_MS1_annotation.py Outdated Show resolved Hide resolved
tools/ipapy2/ipapy2_MS1_annotation.py Outdated Show resolved Hide resolved
tools/ipapy2/ipapy2_MS1_annotation.py Outdated Show resolved Hide resolved
tools/ipapy2/ipapy2_MS1_annotation.py Outdated Show resolved Hide resolved
tools/ipapy2/ipapy2_gibbs_sampler.py Show resolved Hide resolved
tools/ipapy2/ipapy2_gibbs_sampler.xml Outdated Show resolved Hide resolved
tools/ipapy2/ipapy2_gibbs_sampler.xml Outdated Show resolved Hide resolved
tools/ipapy2/ipapy2_map_isotope_patterns.xml Show resolved Hide resolved
tools/ipapy2/ipapy2_map_isotope_patterns.xml Outdated Show resolved Hide resolved

https://github.com/francescodc87/ipaPy2#usage

https://academic.oup.com/bioinformatics/article/39/7/btad455/7230779
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the citation annotations for this. Freetext is very unstructured. If you add this to structured elements Galaxy can do some cool stuff with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants