qubes-i3-sensible-terminal: use qrexec-client directly #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lczerner
force-pushed
the
fix_i3_sensible_terminal
branch
from
437586c to
fd44e40
Compare
Currently qvm-run is used to start a terminal in a vm. However this will keep stdin/stdout connected depleting inter-VM shared memory which is a limited resource (as pointed out by Marek Marczykowski-Górecki). To avoid this, use qrexec-client directly with "-e" option to avoid connecting stdin/stdout. Note that qvm-run does not support this option at the moment, but it could be worked around by pointing stdin/stdout to /dev/null. However using qrexec-cliend seems like a more efficient solution in this case. This should be fine since a running vm is already required to be able to use qubes-i3-sensible-terminal. QubesOS/qubes-issues#5969 Signed-off-by: Lukas Czerner <[email protected]>
lczerner
force-pushed
the
fix_i3_sensible_terminal
branch
from
fd44e40 to
fcbc05e
Compare
|
Ok, I give up :) My keys are not expired, I even updated it on the keyserver but it still says expired. No idea how to fix this. |
This particular one is about the copy of your key on github. But the one on the keyservers seems fine. |
marmarek
approved these changes
Sep 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently qvm-run is used to start a terminal in a vm. However this will
keep stdin/stdout connected depleting inter-VM shared memory which is
a limited resource (as pointed out by Marek Marczykowski-Górecki).
To avoid this use qrexec-client directly with "-e" option to avoid
connecting stdin/stdout.
This should be fine since a running vm is already required to be able to
use qubes-i3-sensible-terminal.
QubesOS/qubes-issues#5969
Signed-off-by: Lukas Czerner [email protected]