Skip to content

Commit

Permalink
qubes-i3-sensible-terminal: use qrexec-client directly
Browse files Browse the repository at this point in the history
Currently qvm-run is used to start a terminal in a vm. However this will
keep stdin/stdout connected depleting inter-VM shared memory which is
a limited resource (as pointed out by Marek Marczykowski-Górecki).

To avoid this use qrexec-client directly with "-e" option to avoid
connecting stdin/stdout.

This should be fine since a running vm is already required to be able to
use qubes-i3-sensible-terminal.

QubesOS/qubes-issues#5969
Signed-off-by: Lukas Czerner <[email protected]>
  • Loading branch information
lczerner committed Aug 27, 2020
1 parent 2cb26ab commit 437586c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion qubes-i3-sensible-terminal
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ get_vm() {
main() {
local vm=$(get_vm)
if [[ -n "$vm" ]]; then
qvm-run "$vm" "bash -c '$run_terminal'"
qrexec-client -e -d "$vm" DEFAULT:"bash -c '$run_terminal'"
else # run terminal in dom0
exec bash -c "$run_terminal"
fi
Expand Down

0 comments on commit 437586c

Please sign in to comment.