Move to @pretendonetwork/eslint-config #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binaryoverload
force-pushed
the
new-eslint
branch
from
9167d77 to
5bbbe03
Compare
jonbarrow
reviewed
Jan 18, 2025
eslint.config.mjs
Outdated
Comment on lines
7
to
8
| 'scripts/*', | ||
| 'dist/*' |
There was a problem hiding this comment.
Idk about scripts, but shouldn't dist be in the common config already? dist feels like something we'd want to ignore everywhere, which makes it common imo
There was a problem hiding this comment.
scripts is just this repo, but I agree with dist - I'll update common accordingly
There was a problem hiding this comment.
@pretendonetwork/eslint-config version 0.0.2 has been updated to include the following ignores which should cover all bases:
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the common eslint config from https://github.com/PretendoNetwork/common-configs/ into the eslint.config.mjs - meaning only repo-specific details need to be added