-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #16 from PretendoNetwork/new-eslint
- Loading branch information
Showing
3 changed files
with
289 additions
and
120 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,113 +1,10 @@ | ||
// @ts-check | ||
import eslintConfig from '@pretendonetwork/eslint-config'; | ||
|
||
/* eslint-disable import/no-named-as-default-member -- We want to be able to use the full package name for the imports here for clarity */ | ||
|
||
import eslint from '@eslint/js'; | ||
import eslintCommentPlugin from '@eslint-community/eslint-plugin-eslint-comments/configs'; | ||
import stylisticPlugin from '@stylistic/eslint-plugin'; | ||
// @ts-expect-error importPlugin is not typed | ||
import importPlugin from 'eslint-plugin-import'; | ||
import tseslint from 'typescript-eslint'; | ||
|
||
/** | ||
* Typed to any as the type is incompatible for some reason - it works! | ||
* @type {any} | ||
*/ | ||
const stylisticConfig = stylisticPlugin.configs.customize({ | ||
indent: 'tab', | ||
quotes: 'single', | ||
semi: true, | ||
commaDangle: 'never', | ||
braceStyle: '1tbs' | ||
}); | ||
|
||
/** | ||
* Typed to any as the type is incompatible for some reason - it works! | ||
* @type {any} | ||
*/ | ||
const eslintCommentPluginConfig = eslintCommentPlugin.recommended; | ||
|
||
export default tseslint.config( | ||
{ | ||
// https://eslint.org/docs/rules/ | ||
extends: [eslint.configs.recommended], | ||
rules: { | ||
'require-atomic-updates': 'off', // This rule is widely controversial and causes false positives | ||
'no-console': 'off', | ||
'prefer-const': 'error', | ||
'no-var': 'error', | ||
'no-unused-vars': 'off', | ||
'one-var': ['error', 'never'] | ||
} | ||
}, | ||
{ | ||
// https://typescript-eslint.io/rules/ | ||
extends: [tseslint.configs.recommended], | ||
rules: { | ||
'@typescript-eslint/no-unused-vars': [ | ||
'error', | ||
{ argsIgnorePattern: '^_' } | ||
], | ||
'@typescript-eslint/no-inferrable-types': 'off', | ||
'@typescript-eslint/explicit-function-return-type': 'error', | ||
'@typescript-eslint/no-explicit-any': 'off', | ||
'@typescript-eslint/no-empty-object-type': ['off'], | ||
'@typescript-eslint/no-import-type-side-effects': 'error', | ||
'@typescript-eslint/consistent-type-imports': ['error', { | ||
fixStyle: 'separate-type-imports' | ||
}] | ||
} | ||
}, | ||
{ | ||
// https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/ | ||
extends: [eslintCommentPluginConfig], | ||
rules: { | ||
'@eslint-community/eslint-comments/disable-enable-pair': ['error', { allowWholeFile: true }], | ||
'@eslint-community/eslint-comments/require-description': 'error' | ||
} | ||
}, | ||
{ | ||
// https://eslint.style/rules | ||
extends: [stylisticConfig], | ||
rules: { | ||
'@stylistic/no-extra-semi': 'error', | ||
'@stylistic/yield-star-spacing': ['error', 'after'], | ||
'@stylistic/operator-linebreak': ['error', 'after', { overrides: { '?': 'before', ':': 'before' } }], | ||
'@stylistic/curly-newline': ['error', { | ||
multiline: true, | ||
consistent: true | ||
}], | ||
'@stylistic/object-curly-newline': ['error', { | ||
multiline: true, | ||
consistent: true | ||
}] | ||
} | ||
}, | ||
{ | ||
// https://www.npmjs.com/package/eslint-plugin-import | ||
extends: [importPlugin.flatConfigs.recommended, importPlugin.flatConfigs.warnings, importPlugin.flatConfigs.typescript], | ||
settings: { | ||
'import/resolver': { | ||
typescript: { | ||
alwaysTryTypes: true, | ||
project: './tsconfig.json' | ||
}, | ||
node: true | ||
} | ||
}, | ||
rules: { | ||
'import/order': ['warn', { | ||
'groups': ['builtin', 'external', 'internal', 'parent', 'sibling', 'index', 'object', 'type'], | ||
'newlines-between': 'never' | ||
}], | ||
'import/first': 'error', | ||
'import/consistent-type-specifier-style': ['error', 'prefer-top-level'] | ||
} | ||
}, | ||
export default [ | ||
...eslintConfig, | ||
{ | ||
ignores: [ | ||
'scripts/*', | ||
'dist/*' | ||
'scripts/*' | ||
] | ||
} | ||
); | ||
]; |
Oops, something went wrong.