Add fast forward/rewind functionality #542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR prepares the core library for testing. It also creates a helloworld test to be used as a template later on.
…ierfrancescoSoffritti#521) This pull requests fixes a bug that prevented users from registering onClick/onLongCLick/onTouch listeners on YouTubePlayerView Test: YouTubePlayerViewClickTest.kt Bug: PierfrancescoSoffritti#105
Fix threading bug in UI tests.
This PR starts an emulator and runs all the tests of the core library in Travis CI.
Make web ui the default UI. This change makes web ui the default and replaces the useWebUi attribute with useNativeUi. Test: YoutubePlayerViewDefaultWebUITest.kt Bug: PierfrancescoSoffritti#475
Adds a customizable fast forward/rewind view that can be used for seeking the player Bug: PierfrancescoSoffritti#132
|
Hi, This closes #132. But I've not included tests, because I found they would be unreliable and I need more time to figure out how to best make them for these changes. In the meantime, here is what I have so far ( proceed with caution, its not the cleanest code out there xD ) |
|
Hey, the animation looks amazing, well done :) I will try to go through the code tomorrow. |
|
Hello @PierfrancescoSoffritti. Any update of this feature being merged? |
PierfrancescoSoffritti
force-pushed
the
dev
branch
from
17f06cc to
0df9b92
Compare
|
Custom UI has been removed. See 11.0.0 release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a customizable fast forward/rewind view that can be used for seeking the player
Bug: #132