Skip to content

Commit

Permalink
Remove latest changes
Browse files Browse the repository at this point in the history
The latest changes are substanstial and have been made by community
members. While the help is very appreciated i don't have much time
to spend on the lib, so was not able to verify that those changes
are not breaking things. So in order to be safe and be able to
relase updates to the library i decided the easies way to move
forward is to remove the changes. As i don't have time to make sure
they are safe.
  • Loading branch information
Pierfrancesco Soffritti committed Aug 9, 2021
1 parent 50c2499 commit 0df9b92
Show file tree
Hide file tree
Showing 5 changed files with 39 additions and 14 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
/.idea/workspace.xml
/.idea/libraries
/.idea/dictionaries
/.idea/gradle.xml
.DS_Store
/build
/captures
6 changes: 6 additions & 0 deletions .idea/compiler.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions .idea/jarRepositories.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions .idea/modules.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 6 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@ A lengthier explanation to why you may want to consider using an alternative to
A list of published apps that are using this library: ([let me know](https://github.com/PierfrancescoSoffritti/android-youtube-player/issues) if you want to add your app to this list)

- [reddit is fun](https://play.google.com/store/apps/details?id=com.andrewshu.android.reddit)
- [Shuffly](https://play.google.com/store/apps/details?id=com.pierfrancescosoffritti.shuffly)
- [Musibook](https://play.google.com/store/apps/details?id=com.spians.music.billboard)
- [Mobile Movie Database](https://play.google.com/store/apps/details?id=com.tmdb.themoviedatabase)
- [Curated](https://play.google.com/store/apps/details?id=com.rockspin.weaveapp)
- [dingo](https://play.google.com/store/apps/details?id=com.dingo)

![showcase](./images/showcase.jpg)
Expand Down Expand Up @@ -112,7 +109,7 @@ Also remember when publishing your app on the PlayStore to write title and descr
:memo: Both the **core module** and the **chromecast module** have a sample app, to provide examples of usage of the libraries.

* [Go to source code of **core** sample app](./core-sample-app/).
* [Go to soruce code of **chromecast-sender** sample app](./chromecast-sender-sample-app).
* [Go to source code of **chromecast-sender** sample app](./chromecast-sender-sample-app).

:calling: You can also download and install the apks of both sample apps.

Expand Down Expand Up @@ -245,7 +242,7 @@ This attribute expects a `String`, which is the id of a YouTube video.

**If not set**, the player won't automatically play.

In general you should use this attribute if you want your player to play only one video. This is not a rule, just best practice. In fact, even if you set the attribute it is still possible to play other videos programatically.
In general you should use this attribute if you want your player to play only one video. This is not a rule, just best practice. In fact, even if you set the attribute it is still possible to play other videos programmatically.

#### autoPlay
This attribute expects a `boolean`. Its default value is `false`.
Expand Down Expand Up @@ -851,7 +848,7 @@ PlayerUiController.setMenuButtonClickListener(@NonNull View.OnClickListener cust

By default the menu icon is not visible.

The default `OnClickListener` opens the menu when the menu icon is clicked. You can change this behaviour, for example to open a menu with a different UX, like a bottom sheet panel. Obviously if you want a UX different from the one provided by the library, you are responsible for creating your own components.
The default `OnClickListener` opens the menu when the menu icon is clicked. You can change this behavior, for example to open a menu with a different UX, like a bottom sheet panel. Obviously if you want a UX different from the one provided by the library, you are responsible for creating your own components.

*Menu screenshot:*

Expand Down Expand Up @@ -974,7 +971,7 @@ public final class CastOptionsProvider implements com.google.android.gms.cast.fr
```
You can read how to get a `receiverId` [here](#registration).

Add the `OptionsProvider` to your `manifest.xml`file.
Add the `OptionsProvider` to your `manifest.xml` file.

*(`OPTIONS_PROVIDER_CLASS_NAME` is meant to be like that, change only the `android:value` attribute)*
```xml
Expand Down Expand Up @@ -1082,7 +1079,7 @@ You can call `loadVideo`, `cueVideo`, `pause`, `play` etc.. on the `YouTubePlaye

For how to use the `YouTubePlayer` object and `YouTubePlayerListener`, you can refer to the documentation for the *core* library, [YouTubePlayer](#youtubeplayer).

This example can be found [in the chromecast-sender sample app](./chromecast-sender-sample-app/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/chromecast/sampleapp/examples/basicExample/BasicExampleActivity.kt), written in Kotlin and in the [core sample app](./core-sample-app/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/core/sampleapp/examples/chromecastExample/), wirtten in Java.
This example can be found [in the chromecast-sender sample app](./chromecast-sender-sample-app/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/chromecast/sampleapp/examples/basicExample/BasicExampleActivity.kt), written in Kotlin and in the [core sample app](./core-sample-app/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/core/sampleapp/examples/chromecastExample/), written in Java.

*Screenshot of the CastButton added to the YouTubePlayerView:*

Expand All @@ -1095,7 +1092,7 @@ You don't need to change anything here, it just works.
Take this code and upload it (as it is) on your server. (Read the [hosting paragraph](#hosting-the-chromecast-receiver) to learn more about hosting).

### Registration
In order to use your receiver you need a receiverId. This is the ID of your receiver app. To get a receiver ID you need to register your receiver on the Google Cast SDK developer console, you can learn how to do it by reading the [official documentation](https://developers.google.com/cast/docs/registration). Rember to register a **Custom Receiver**, this is the type of receiver you need for this library.
In order to use your receiver you need a receiverId. This is the ID of your receiver app. To get a receiver ID you need to register your receiver on the Google Cast SDK developer console, you can learn how to do it by reading the [official documentation](https://developers.google.com/cast/docs/registration). Remember to register a **Custom Receiver**, this is the type of receiver you need for this library.

### Hosting the chromecast-receiver
You will be required to host your receiver somewhere, host it where you prefer. Firebase free hosting may be a good option, for development.
Expand Down

0 comments on commit 0df9b92

Please sign in to comment.