Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double tap to go forward/backward in DefaultPlayerUIController #132

Open
PierfrancescoSoffritti opened this issue May 10, 2018 · 4 comments

Comments

@PierfrancescoSoffritti
Copy link
Owner

No description provided.

@rajeefmk
Copy link
Contributor

rajeefmk commented Jun 29, 2018

@PierfrancescoSoffritti
If you notice the youtube app, its buggy most of the time since half the time, I wasn't sure where to tap and until the tap is made, the control views also doesn't come up.

  1. Are we going with similar approach of double tap on screen ?
  2. Or should we introduce the -10 & +10s icons to the left and right of the play/pause button ? (Similar to what Amazon prime does ? (The iOS youtube app also has a similar approach except that the +10 and -10s are on the bottom bar).

@PierfrancescoSoffritti
Copy link
Owner Author

Solution number 2 is basically already implemented, using setCustomAction1 and setCustomAction2. It's just a matter of doing seekTo(time +- 10). Users of the library can take care of that.

I think solution 1 is more interesting. It shouldn't be too hard to achieve, all is needed are 2 transparent views that cover one half of the screen each. These views can then be used to detect double taps.

I think the trickiest thing to implement (but i may be wrong) may be the detection of multiple double taps. eg: if the user taps 4 times on the right view, the player should seek to currentTime + 20 instead of currentTime + 10.

@rajeefmk
Copy link
Contributor

Ha. That's interesting. I just checked out the latest youtube app and the double tap issue seems to be fixed and it's working beautifully.

Also, about the multiple double tap, I think once the first double tap activates the fast forward (backward) mode, then the player doesn't differentiate between single/double tap. I was able to increment in single 10s counts also.

Let's try and emulate the exact behavior of the native app. Would be happy to take this up.

@PierfrancescoSoffritti
Copy link
Owner Author

You're right. After the first two taps it's only one to skip 10 seconds.

Sounds great to me, thanks for helping :)

Repository owner deleted a comment from ashish-bahl Oct 10, 2018
Repository owner deleted a comment from ashish-bahl Oct 10, 2018
AbelTesfaye added a commit to AbelTesfaye/android-youtube-player that referenced this issue Mar 27, 2020
Adds a customizable fast forward/rewind view that can be used for seeking the player

Bug: PierfrancescoSoffritti#132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants