Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce support for Live-VOD mode for live streams #155

Conversation

rajeefmk
Copy link
Contributor

The changes included are :

  • Introduced Live-VOD (Video on Demand) mode similar which is enabled when user moves the seekbar during live stream.
  • Live stream indicator tag is made clickable and now has the same functionality as that of native app wherein it'll restore the live state.
  • Seekbar is always visible now and during Live stream, it's progress position value will be that of the video duration.

@PierfrancescoSoffritti
Copy link
Owner

Great, thanks! expect it available in v8 soon :)

@PierfrancescoSoffritti
Copy link
Owner

If you'd like to take on other issues just let me know!

@rajeefmk
Copy link
Contributor Author

@PierfrancescoSoffritti Absolutely.

@PierfrancescoSoffritti
Copy link
Owner

issue 132
this one is similar to the one you just sent

issue 71
this one is also about implementing features from the YouTube app, but probably a bit more challenging

@rajeefmk
Copy link
Contributor Author

@PierfrancescoSoffritti What a coincidence ! I was actually going through this #132 very same ticket.

Continuing the discussion there.

@PierfrancescoSoffritti
Copy link
Owner

I've been testing the new live controls, it's really hard to ensure consistency. The available buffer for some live videos appears to be of 2 hours, for other is different. Therefore is basically impossible to map correctly the video's duration on the seekbar.
Almost all the time, when manually seeking to the start or end of the seekbar the behavior is inconsistent.

I have been trying to find a solution to these problems but I haven't been able to. Do you have any ideas? If it's not possible to solve these issues I'm afraid I will have to revert the changes :/

@rajeefmk
Copy link
Contributor Author

rajeefmk commented Jul 3, 2018

@PierfrancescoSoffritti You're absolutely right. So the seekbar behaviour is directly dependent on how on the total duration of the live session and not precisely when the actual broadcast started. This will definitely create inconsistency.

I think you'll have to go ahead revert the changes :/ Sorry about that !

@PierfrancescoSoffritti
Copy link
Owner

No worries, it is quite tricky actually. The buffer is behaving like a sliding window, not sure yet how we could implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants